Issue a PUT request after a GET request responding with 202 and a Location header #2099
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For future consideration, it might be worth removing the |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
https://messages.cucumber.ioservice responds with 413 Payload Too Large for message files larger than 6 Mb. This was discovered during a chat with one of our users.We've adopted the solution outlined in Option 2 in this blog post. A
GET https://messages.cucumber.io/api/reportsrequest will now respond with202 Acceptedand aLocationheader pointing to S3.This is not a proper redirect, so we're handling this in the code by issuing a new
PUTrequest if the status is202and theLocationheader is present.This change preserves backwards compatibility for all HTTP verbs except
GET. However, this change in behaviour will only manifest itself for users issuingGETrequest to servers expecting a body in the request, which is legal, but not useful. We don't expect anyone to be affected.For this reason we consider this change to be an addition, which should trigger a minor release.
The same change has been applied to Ruby.